apollo_propeller: add ShardSignatureVerificationError

[sirandreww-starkware]

No description provided.

[github-actions]

Artifacts upload workflows:

• Started at 2025-12-24T12:45:42Z
• Started at 2026-01-04T17:07:53Z
• Started at 2026-01-12T14:23:01Z
• Started at 2026-01-12T14:23:00Z
• Started at 2026-01-13T10:54:59Z
• Started at 2026-01-13T15:06:22Z
• Started at 2026-01-14T08:05:26Z
• Started at 2026-01-14T08:05:57Z

[sirandreww-starkware]

• apollo_propeller: add minimal config #11196 : 2 dependent PRs (#11197 , #11942 )
• apollo_propeller: add behaviour skeleton #11195
• apollo_propeller: add Event enum to types #11194
• apollo_propeller: add dial upgrade error handling to handler #11074
• apollo_propeller: add rate-limited queue length warnings #11073
• apollo_propeller: add concurrent streams support to handler #11072
• apollo_propeller: implement outbound substream with message batching #11071
• apollo_propeller: add handler helper methods #11070
• apollo_propeller: use protobuf type in handler send queue #11069
• apollo_propeller: reorder handler structs #11068
• apollo_propeller: add inbound substream handling to receive units #11067
• apollo_propeller: add receive queue and emit logic to handler #11066
• apollo_propeller: add handler skeleton with TODOs #11065
• apollo_propeller: add protocol upgrade for libp2p streams #11064
• apollo_protobuf: add prost codec for length-delimited messages #11063
• apollo_propeller: add protobuf conversions for PropellerUnit #11062
• apollo_propeller: add merkle proof verification to validator #11061
• apollo_propeller: integrate tree origin verification in validator #11060
• apollo_propeller: add tree origin verification methods #11059
• apollo_propeller: add unit validator with signature caching #11058
• apollo_propeller: add tree topology core logic #11057
• apollo_propeller: add shard validation error type #11056
• apollo_propeller: add peer set error type #11055
• apollo_propeller: add core unit struct with accessors #11054
• apollo_propeller: add signature verification module #11053
• apollo_propeller: add reconstruction error type #11052
• apollo_propeller: add shard publish error type #11051
• apollo_propeller: add tree generation error type #11050
• apollo_propeller: add ShardSignatureVerificationError #11049 👈 (View in Graphite)
• apollo_propeller: add base types (Channel, ShardIndex, MessageRoot) #11048
• apollo_propeller: add reed-solomon erasure coding #11047
• apollo_propeller: added merkle implementation tests #11206 : 1 other dependent PR (#11572 )
• apollo_propeller: added merkle tree builder #11205
• apollo_propeller: added model merkle implementation #10985
• apollo_propeller: added model merkle proof implementation #11204
• apollo_protobuf: added propeller proto file #10654
• apollo_propeller: new crate for the propeller p2p protocol #11192
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[guy-starkware]

@guy-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware, @ShahakShama, and @sirandreww-starkware).

---

crates/apollo_propeller/src/types.rs line 70 at r2 (raw file):

        }
    }
}

I think the way we usually do it is implement Error and then add annotations above each variant.

Code quote:

impl std::fmt::Display for ShardSignatureVerificationError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            ShardSignatureVerificationError::NoPublicKeyAvailable(publisher) => {
                write!(f, "No public key available for signer {}", publisher)
            }
            ShardSignatureVerificationError::EmptySignature => {
                write!(f, "Shard has empty signature")
            }
            ShardSignatureVerificationError::VerificationFailed => {
                write!(f, "Shard signature is invalid")
            }
        }
    }
}

[guy-starkware]

@guy-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware, @ShahakShama, and @sirandreww-starkware).

---

crates/apollo_propeller/src/types.rs line 70 at r2 (raw file):

Previously, guy-starkware wrote…

I think the way we usually do it is implement Error and then add annotations above each variant.

I mean thiserror

[ShahakShama]

@ShahakShama reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @guy-starkware, @noamsp-starkware, and @sirandreww-starkware).

---

crates/apollo_propeller/src/types.rs line 70 at r2 (raw file):

Previously, guy-starkware wrote…

I mean thiserror

+1

---

crates/apollo_propeller/src/types.rs line 46 at r2 (raw file):

}

// ****************************************************************************

Remove this

---

crates/apollo_propeller/src/types.rs line 51 at r2 (raw file):

#[derive(Debug, Clone, PartialEq, Eq)]
pub enum ShardSignatureVerificationError {
    NoPublicKeyAvailable(PeerId),

It's unclear whose peer id is this. Make this a named fields variant

[ShahakShama]

@ShahakShama made 1 comment.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @guy-starkware, @noamsp-starkware, and @sirandreww-starkware).

---

a discussion (no related file):
It's hard for me to review these errors without seeing them used. I think that you should start with no variants and add each variant in the PR where you use it for the first time

[sirandreww-starkware]

@sirandreww-starkware made 4 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @guy-starkware, @noamsp-starkware, and @ShahakShama).

---

a discussion (no related file):

Previously, ShahakShama wrote…

It's hard for me to review these errors without seeing them used. I think that you should start with no variants and add each variant in the PR where you use it for the first time

I tried building PRs this way and it was really hard to keep them small. Also at this point this requires a huge change in the PR order/structure. If you give me enough time we can do this but we definitely will not hit our February deadline.

---

crates/apollo_propeller/src/types.rs line 46 at r2 (raw file):

Previously, ShahakShama wrote…

Remove this

please review response in last PR

---

crates/apollo_propeller/src/types.rs line 51 at r2 (raw file):

Previously, ShahakShama wrote…

It's unclear whose peer id is this. Make this a named fields variant

I think it is very clear that this error is saying "I do not know the public key of this PeerID"

---

crates/apollo_propeller/src/types.rs line 70 at r2 (raw file):

Previously, ShahakShama wrote…

+1

I'll add a TODO to do this after this file contains all the error types instead of updating all the PRs that add errors

[guy-starkware]

@guy-starkware reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noamsp-starkware and @ShahakShama).

---

crates/apollo_propeller/src/types.rs line 51 at r2 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

I think it is very clear that this error is saying "I do not know the public key of this PeerID"

I think this is the sort of thing you can get "thiserror" to make explicit. When you reach that TODO above and add thiserror, make sure to spell out the errors so the poor debuggers looking at our logs will have an easy time.

[ShahakShama]

@ShahakShama reviewed all commit messages, made 2 comments, and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @sirandreww-starkware).

---

crates/apollo_propeller/src/types.rs line 46 at r2 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

please review response in last PR

I still think we should remove this

---

crates/apollo_propeller/src/types.rs line 51 at r2 (raw file):

Previously, guy-starkware wrote…

I think this is the sort of thing you can get "thiserror" to make explicit. When you reach that TODO above and add thiserror, make sure to spell out the errors so the poor debuggers looking at our logs will have an easy time.

Fair point @guy-starkware

[sirandreww-starkware]

@sirandreww-starkware made 2 comments.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @guy-starkware, @noamsp-starkware, and @ShahakShama).

---

crates/apollo_propeller/src/types.rs line 46 at r2 (raw file):

Previously, ShahakShama wrote…

I still think we should remove this

Done.

---

crates/apollo_propeller/src/types.rs line 51 at r2 (raw file):

Previously, ShahakShama wrote…

Fair point @guy-starkware

Done
I decided to bite the bullet and do it now that I have your attention

[ShahakShama]

@ShahakShama reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

[ShahakShama]

@ShahakShama made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @sirandreww-starkware).

---

crates/apollo_propeller/src/types.rs line 24 at r4 (raw file):

needs to be provided explicitly
Is that an option? If not, erase that part of the sentence

[graphite-app]

Merge activity

• Jan 14, 8:05 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[sirandreww-starkware]

@sirandreww-starkware reviewed 3 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).