apollo_propeller: add protobuf conversions for PropellerUnit

[sirandreww-starkware]

No description provided.

[sirandreww-starkware]

• apollo_propeller: add minimal config #11196 : 2 dependent PRs (#11197 , #11942 )
• apollo_propeller: add behaviour skeleton #11195
• apollo_propeller: add Event enum to types #11194
• apollo_propeller: add dial upgrade error handling to handler #11074
• apollo_propeller: add rate-limited queue length warnings #11073
• apollo_propeller: add concurrent streams support to handler #11072
• apollo_propeller: implement outbound substream with message batching #11071
• apollo_propeller: add handler helper methods #11070
• apollo_propeller: use protobuf type in handler send queue #11069
• apollo_propeller: reorder handler structs #11068
• apollo_propeller: add inbound substream handling to receive units #11067
• apollo_propeller: add receive queue and emit logic to handler #11066
• apollo_propeller: add handler skeleton with TODOs #11065
• apollo_propeller: add protocol upgrade for libp2p streams #11064
• apollo_protobuf: add prost codec for length-delimited messages #11063
• apollo_propeller: add protobuf conversions for PropellerUnit #11062 👈 (View in Graphite)
• apollo_propeller: add merkle proof verification to validator #11061
• apollo_propeller: integrate tree origin verification in validator #11060
• apollo_propeller: add tree origin verification methods #11059
• apollo_propeller: add unit validator with signature caching #11058
• apollo_propeller: add tree topology core logic #11057
• apollo_propeller: add shard validation error type #11056
• apollo_propeller: add peer set error type #11055
• apollo_propeller: add core unit struct with accessors #11054
• apollo_propeller: add signature verification module #11053
• apollo_propeller: add reconstruction error type #11052
• apollo_propeller: add shard publish error type #11051
• apollo_propeller: add tree generation error type #11050
• apollo_propeller: add ShardSignatureVerificationError #11049
• apollo_propeller: add base types (Channel, ShardIndex, MessageRoot) #11048
• apollo_propeller: add reed-solomon erasure coding #11047
• apollo_propeller: added merkle implementation tests #11206 : 1 other dependent PR (#11572 )
• apollo_propeller: added merkle tree builder #11205
• apollo_propeller: added model merkle implementation #10985
• apollo_propeller: added model merkle proof implementation #11204
• apollo_protobuf: added propeller proto file #10654
• apollo_propeller: new crate for the propeller p2p protocol #11192
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

@sirandreww-starkware made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noamsp-starkware and @ShahakShama).

---

crates/apollo_propeller/src/unit.rs line 85 at r1 (raw file):

Previously, ShahakShama wrote…

Vec<u8>

Doesn't that mean that the proto crate will depend on this crate? and this crate will probably also depend on that crate because it need the conversion? Wouldn't that mean that we need to move unit to that crate as well?

---

crates/apollo_propeller/src/unit.rs line 86 at r1 (raw file):

Previously, ShahakShama wrote…

use ProtobufConversionError

Done.

---

crates/apollo_propeller/src/unit.rs line 140 at r1 (raw file):

Previously, ShahakShama wrote…

why not impl From/TryFrom like before

Done.

[ShahakShama]

@ShahakShama reviewed 3 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @sirandreww-starkware).

---

crates/apollo_propeller/src/unit.rs line 85 at r1 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

Doesn't that mean that the proto crate will depend on this crate? and this crate will probably also depend on that crate because it need the conversion? Wouldn't that mean that we need to move unit to that crate as well?

Move unit to that crate, and then you don't need to have the proto crate depend on this crate

[sirandreww-starkware]

@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama).

---

crates/apollo_propeller/src/unit.rs line 85 at r1 (raw file):

Previously, ShahakShama wrote…

Move unit to that crate, and then you don't need to have the proto crate depend on this crate

I don't want to do that.
It makes the propeller code scattered across 2 crates. Furthermore I don't need Vec<u8> conversion for PropellerUnit.

[ShahakShama]

@ShahakShama reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

[graphite-app]

Merge activity

• Jan 21, 8:50 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[sirandreww-starkware]

@sirandreww-starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).