apollo_propeller: add merkle proof verification to validator#11061
Conversation
ee6b0c6 to
77c60f9
Compare
79f1ab9 to
fe47057
Compare
77c60f9 to
563ec59
Compare
563ec59 to
e57443a
Compare
fe47057 to
3ac4f75
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 6 files and all commit messages, made 2 comments, and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @sirandreww-starkware).
crates/apollo_propeller/src/unit.rs line 75 at r1 (raw file):
Previously, sirandreww-starkware (Andrew Luka) wrote…
Would you like me to change that?
No it's reasonable
crates/apollo_propeller/src/unit_validator_test.rs line 58 at r3 (raw file):
let merkle_tree = MerkleTree::new(&vec![SHARD_DATA.to_vec(); NUM_PEERS - 1]); let message_root = MessageRoot(merkle_tree.root().unwrap());
Again, use automock
3ac4f75 to
ff13078
Compare
5e823b0 to
eb78161
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama).
crates/apollo_propeller/src/unit_validator_test.rs line 58 at r3 (raw file):
Previously, ShahakShama wrote…
Again, use automock
added a TODO
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).
ff13078 to
e1fc051
Compare
74f9b1b to
8881b8b
Compare
e1fc051 to
6260ed0
Compare
8881b8b to
600ad4d
Compare
Merge activity
|
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

No description provided.