Skip to content

apollo_propeller: add merkle proof verification to validator#11061

Merged
sirandreww-starkware merged 1 commit intomain-v0.14.1-committerfrom
12-24-apollo_propeller_add_merkle_proof_verification_to_validator
Jan 21, 2026
Merged

apollo_propeller: add merkle proof verification to validator#11061
sirandreww-starkware merged 1 commit intomain-v0.14.1-committerfrom
12-24-apollo_propeller_add_merkle_proof_verification_to_validator

Conversation

@sirandreww-starkware
Copy link
Contributor

No description provided.

Copy link
Contributor Author

sirandreww-starkware commented Dec 24, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link

This change is Reviewable

@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11061 to 12-24-apollo_propeller_integrate_tree_origin_verification_in_validator January 15, 2026 17:53
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_merkle_proof_verification_to_validator branch from ee6b0c6 to 77c60f9 Compare January 18, 2026 09:26
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_integrate_tree_origin_verification_in_validator branch 2 times, most recently from 79f1ab9 to fe47057 Compare January 19, 2026 11:18
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_merkle_proof_verification_to_validator branch from 77c60f9 to 563ec59 Compare January 19, 2026 11:18
@sirandreww-starkware sirandreww-starkware changed the base branch from 12-24-apollo_propeller_integrate_tree_origin_verification_in_validator to graphite-base/11061 January 19, 2026 14:07
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_merkle_proof_verification_to_validator branch from 563ec59 to e57443a Compare January 19, 2026 14:35
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11061 to 12-24-apollo_propeller_integrate_tree_origin_verification_in_validator January 19, 2026 14:35
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 6 files and all commit messages, made 2 comments, and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @sirandreww-starkware).


crates/apollo_propeller/src/unit.rs line 75 at r1 (raw file):

Previously, sirandreww-starkware (Andrew Luka) wrote…

Would you like me to change that?

No it's reasonable


crates/apollo_propeller/src/unit_validator_test.rs line 58 at r3 (raw file):

    let merkle_tree = MerkleTree::new(&vec![SHARD_DATA.to_vec(); NUM_PEERS - 1]);
    let message_root = MessageRoot(merkle_tree.root().unwrap());

Again, use automock

@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_integrate_tree_origin_verification_in_validator branch from 3ac4f75 to ff13078 Compare January 20, 2026 10:02
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_merkle_proof_verification_to_validator branch 2 times, most recently from 5e823b0 to eb78161 Compare January 20, 2026 10:11
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama).


crates/apollo_propeller/src/unit_validator_test.rs line 58 at r3 (raw file):

Previously, ShahakShama wrote…

Again, use automock

added a TODO

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_integrate_tree_origin_verification_in_validator branch from ff13078 to e1fc051 Compare January 20, 2026 12:41
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_merkle_proof_verification_to_validator branch 2 times, most recently from 74f9b1b to 8881b8b Compare January 21, 2026 07:19
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_integrate_tree_origin_verification_in_validator branch from e1fc051 to 6260ed0 Compare January 21, 2026 07:19
@sirandreww-starkware sirandreww-starkware changed the base branch from 12-24-apollo_propeller_integrate_tree_origin_verification_in_validator to main-v0.14.1-committer January 21, 2026 07:48
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_merkle_proof_verification_to_validator branch from 8881b8b to 600ad4d Compare January 21, 2026 07:48
@graphite-app
Copy link

graphite-app bot commented Jan 21, 2026

Merge activity

  • Jan 21, 7:49 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 6 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main-v0.14.1-committer with commit d297cf8 Jan 21, 2026
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments