apollo_propeller: add tree generation error type

[sirandreww-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

• apollo_propeller: add minimal config #11196 : 2 dependent PRs (#11197 , #11942 )
• apollo_propeller: add behaviour skeleton #11195
• apollo_propeller: add Event enum to types #11194
• apollo_propeller: add dial upgrade error handling to handler #11074
• apollo_propeller: add rate-limited queue length warnings #11073
• apollo_propeller: add concurrent streams support to handler #11072
• apollo_propeller: implement outbound substream with message batching #11071
• apollo_propeller: add handler helper methods #11070
• apollo_propeller: use protobuf type in handler send queue #11069
• apollo_propeller: reorder handler structs #11068
• apollo_propeller: add inbound substream handling to receive units #11067
• apollo_propeller: add receive queue and emit logic to handler #11066
• apollo_propeller: add handler skeleton with TODOs #11065
• apollo_propeller: add protocol upgrade for libp2p streams #11064
• apollo_protobuf: add prost codec for length-delimited messages #11063
• apollo_propeller: add protobuf conversions for PropellerUnit #11062
• apollo_propeller: add merkle proof verification to validator #11061
• apollo_propeller: integrate tree origin verification in validator #11060
• apollo_propeller: add tree origin verification methods #11059
• apollo_propeller: add unit validator with signature caching #11058
• apollo_propeller: add tree topology core logic #11057
• apollo_propeller: add shard validation error type #11056
• apollo_propeller: add peer set error type #11055
• apollo_propeller: add core unit struct with accessors #11054
• apollo_propeller: add signature verification module #11053
• apollo_propeller: add reconstruction error type #11052
• apollo_propeller: add shard publish error type #11051
• apollo_propeller: add tree generation error type #11050 👈 (View in Graphite)
• apollo_propeller: add ShardSignatureVerificationError #11049
• apollo_propeller: add base types (Channel, ShardIndex, MessageRoot) #11048
• apollo_propeller: add reed-solomon erasure coding #11047
• apollo_propeller: added merkle implementation tests #11206 : 1 other dependent PR (#11572 )
• apollo_propeller: added merkle tree builder #11205
• apollo_propeller: added model merkle implementation #10985
• apollo_propeller: added model merkle proof implementation #11204
• apollo_protobuf: added propeller proto file #10654
• apollo_propeller: new crate for the propeller p2p protocol #11192
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[guy-starkware]

@guy-starkware reviewed 1 file.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware, @ShahakShama, and @sirandreww-starkware).

[ShahakShama]

@ShahakShama reviewed all commit messages and made 2 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noamsp-starkware and @sirandreww-starkware).

---

a discussion (no related file):
It's hard for me to review these errors without seeing them used. I think that you should start with no variants and add each variant in the PR where you use it for the first time

---

crates/apollo_propeller/src/types.rs line 74 at r1 (raw file):

impl std::error::Error for ShardSignatureVerificationError {}

// ****************************************************************************

remove this

[sirandreww-starkware]

@sirandreww-starkware made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @guy-starkware, @noamsp-starkware, and @ShahakShama).

---

a discussion (no related file):

Previously, ShahakShama wrote…

It's hard for me to review these errors without seeing them used. I think that you should start with no variants and add each variant in the PR where you use it for the first time

Please see previous PR

---

crates/apollo_propeller/src/types.rs line 74 at r1 (raw file):

Previously, ShahakShama wrote…

remove this

see previous PR

---

crates/apollo_propeller/src/types.rs line 106 at r1 (raw file):

Previously, guy-starkware wrote…

same comment as previous PR

see previous PR

[guy-starkware]

@guy-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware and @ShahakShama).

[ShahakShama]

@ShahakShama reviewed all commit messages, made 6 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @noamsp-starkware and @sirandreww-starkware).

---

crates/apollo_propeller/src/types.rs line 79 at r2 (raw file):

#[derive(Debug, Clone, PartialEq, Eq)]
pub enum TreeGenerationError {

When is this error used? Where do you generate trees in propeller? Maybe we can find a better name than TreeGeneration

---

crates/apollo_propeller/src/types.rs line 80 at r2 (raw file):

#[derive(Debug, Clone, PartialEq, Eq)]
pub enum TreeGenerationError {
    PublisherNotFound {

Rename to PublisherNotInChannel

---

crates/apollo_propeller/src/types.rs line 84 at r2 (raw file):

        publisher: PeerId,
    },
    LocalPeerNotInPeerWeights,

Same here. LocalPeerNotInChannel

---

crates/apollo_propeller/src/types.rs line 84 at r2 (raw file):

        publisher: PeerId,
    },
    LocalPeerNotInPeerWeights,

It's not clear what local peer means

---

crates/apollo_propeller/src/types.rs line 91 at r2 (raw file):

}

impl std::fmt::Display for TreeGenerationError {

Remove this and use thiserror instead. You can just have a TODO for now

---

crates/apollo_propeller/src/types.rs line 110 at r2 (raw file):

}

impl std::error::Error for TreeGenerationError {}

Same here

[ShahakShama]

@ShahakShama resolved 1 discussion.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @noamsp-starkware and @sirandreww-starkware).

[sirandreww-starkware]

@sirandreww-starkware made 6 comments.
Reviewable status: 0 of 1 files reviewed, 6 unresolved discussions (waiting on @guy-starkware, @noamsp-starkware, and @ShahakShama).

---

crates/apollo_propeller/src/types.rs line 79 at r2 (raw file):

Previously, ShahakShama wrote…

When is this error used? Where do you generate trees in propeller? Maybe we can find a better name than TreeGeneration

so, TreeGenerationError is the error you get when trying to gauge the topology of the channel. Actions that may return this error are:

1. you receive shard x and you want to know who is the peer that should send you this shard
2. you want to see what shard you are responsible for

---

crates/apollo_propeller/src/types.rs line 80 at r2 (raw file):

Previously, ShahakShama wrote…

Rename to PublisherNotInChannel

Done.

---

crates/apollo_propeller/src/types.rs line 84 at r2 (raw file):

Previously, ShahakShama wrote…

It's not clear what local peer means

What would be a better name for "me"?

---

crates/apollo_propeller/src/types.rs line 84 at r2 (raw file):

Previously, ShahakShama wrote…

Same here. LocalPeerNotInChannel

Done.

---

crates/apollo_propeller/src/types.rs line 91 at r2 (raw file):

Previously, ShahakShama wrote…

Remove this and use thiserror instead. You can just have a TODO for now

not sure what this is referring to or if it is outdated. Please resolve if it is outdated.

---

crates/apollo_propeller/src/types.rs line 110 at r2 (raw file):

Previously, ShahakShama wrote…

Same here

not sure what this is referring to or if it is outdated. Please resolve if it is outdated.

[ShahakShama]

@ShahakShama reviewed 1 file and all commit messages, and resolved 6 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

[ShahakShama]

@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

[graphite-app]

Merge activity

• Jan 15, 8:36 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.