apollo_propeller: add shard publish error type

[sirandreww-starkware]

No description provided.

[sirandreww-starkware]

• apollo_propeller: add minimal config #11196 : 2 dependent PRs (#11197 , #11942 )
• apollo_propeller: add behaviour skeleton #11195
• apollo_propeller: add Event enum to types #11194
• apollo_propeller: add dial upgrade error handling to handler #11074
• apollo_propeller: add rate-limited queue length warnings #11073
• apollo_propeller: add concurrent streams support to handler #11072
• apollo_propeller: implement outbound substream with message batching #11071
• apollo_propeller: add handler helper methods #11070
• apollo_propeller: use protobuf type in handler send queue #11069
• apollo_propeller: reorder handler structs #11068
• apollo_propeller: add inbound substream handling to receive units #11067
• apollo_propeller: add receive queue and emit logic to handler #11066
• apollo_propeller: add handler skeleton with TODOs #11065
• apollo_propeller: add protocol upgrade for libp2p streams #11064
• apollo_protobuf: add prost codec for length-delimited messages #11063
• apollo_propeller: add protobuf conversions for PropellerUnit #11062
• apollo_propeller: add merkle proof verification to validator #11061
• apollo_propeller: integrate tree origin verification in validator #11060
• apollo_propeller: add tree origin verification methods #11059
• apollo_propeller: add unit validator with signature caching #11058
• apollo_propeller: add tree topology core logic #11057
• apollo_propeller: add shard validation error type #11056
• apollo_propeller: add peer set error type #11055
• apollo_propeller: add core unit struct with accessors #11054
• apollo_propeller: add signature verification module #11053
• apollo_propeller: add reconstruction error type #11052
• apollo_propeller: add shard publish error type #11051 👈 (View in Graphite)
• apollo_propeller: add tree generation error type #11050
• apollo_propeller: add ShardSignatureVerificationError #11049
• apollo_propeller: add base types (Channel, ShardIndex, MessageRoot) #11048
• apollo_propeller: add reed-solomon erasure coding #11047
• apollo_propeller: added merkle implementation tests #11206 : 1 other dependent PR (#11572 )
• apollo_propeller: added merkle tree builder #11205
• apollo_propeller: added model merkle implementation #10985
• apollo_propeller: added model merkle proof implementation #11204
• apollo_protobuf: added propeller proto file #10654
• apollo_propeller: new crate for the propeller p2p protocol #11192
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[guy-starkware]

@guy-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware and @ShahakShama).

[ShahakShama]

@ShahakShama reviewed all commit messages and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware and @sirandreww-starkware).

---

crates/apollo_propeller/src/types.rs line 121 at r2 (raw file):

    SigningFailed(String),
    ErasureEncodingFailed(String),
    NotConnectedToPeer(PeerId),

We don't want to fail on a single peer disconnected. Sending will still succeed as long as there's no 1/3 peers not connected

---

crates/apollo_propeller/src/types.rs line 122 at r2 (raw file):

    ErasureEncodingFailed(String),
    NotConnectedToPeer(PeerId),
    HandlerError(String),

This is unclear

[sirandreww-starkware]

@sirandreww-starkware made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @guy-starkware, @noamsp-starkware, and @ShahakShama).

---

crates/apollo_propeller/src/types.rs line 121 at r2 (raw file):

Previously, ShahakShama wrote…

We don't want to fail on a single peer disconnected. Sending will still succeed as long as there's no 1/3 peers not connected

failure does not have to mean we stop the receiving, here it will be used to propagate an event to the network manager so it knows about it and hopefully works on establishing a connection. It ties into discovery, but this is just to inform the user of the behavior that "I failed but it's not my fault"

---

crates/apollo_propeller/src/types.rs line 122 at r2 (raw file):

Previously, ShahakShama wrote…

This is unclear

Very fair, added a TODO to change this and elaborate when it is used (possibly we'll change the type as well)

[ShahakShama]

@ShahakShama reviewed 1 file and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

[graphite-app]

Merge activity

• Jan 15, 8:52 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[sirandreww-starkware]

@sirandreww-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).