apollo_propeller: add protocol upgrade for libp2p streams#11064
Conversation
b4c0020 to
fc2a8bb
Compare
237aaa5 to
ed1921e
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama).
crates/apollo_propeller/src/protocol.rs line 21 at r1 (raw file):
Previously, ShahakShama wrote…
I'm not worried about performance, I'm worried about code readability. Having to pass this all around makes the code more messy. if we decide to have versions with backward compatibility (which I doubt we'll do), then we can change it back
I'll add a todo since this change requires changes in the behaviour and config files
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).
ed1921e to
7f6f8ed
Compare
fc2a8bb to
1c7eae9
Compare
1c7eae9 to
b835990
Compare
7f6f8ed to
416902f
Compare
416902f to
79d942e
Compare
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).
7805f2d

No description provided.