Skip to content

apollo_propeller: add protocol upgrade for libp2p streams#11064

Merged
sirandreww-starkware merged 1 commit intomain-v0.14.1-committerfrom
12-24-apollo_propeller_add_protocol_upgrade_for_libp2p_streams
Jan 27, 2026
Merged

apollo_propeller: add protocol upgrade for libp2p streams#11064
sirandreww-starkware merged 1 commit intomain-v0.14.1-committerfrom
12-24-apollo_propeller_add_protocol_upgrade_for_libp2p_streams

Conversation

@sirandreww-starkware
Copy link
Contributor

No description provided.

Copy link
Contributor Author

sirandreww-starkware commented Dec 24, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama).


crates/apollo_propeller/src/protocol.rs line 21 at r1 (raw file):

Previously, ShahakShama wrote…

I'm not worried about performance, I'm worried about code readability. Having to pass this all around makes the code more messy. if we decide to have versions with backward compatibility (which I doubt we'll do), then we can change it back

I'll add a todo since this change requires changes in the behaviour and config files

@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11064 to 12-24-apollo_propeller_add_prost_codec_for_length-delimited_messages January 27, 2026 07:58
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

@sirandreww-starkware sirandreww-starkware changed the base branch from 12-24-apollo_propeller_add_prost_codec_for_length-delimited_messages to graphite-base/11064 January 27, 2026 09:21
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_protocol_upgrade_for_libp2p_streams branch from ed1921e to 7f6f8ed Compare January 27, 2026 09:22
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11064 to 12-24-apollo_propeller_add_prost_codec_for_length-delimited_messages January 27, 2026 09:22
@sirandreww-starkware sirandreww-starkware changed the base branch from 12-24-apollo_propeller_add_prost_codec_for_length-delimited_messages to graphite-base/11064 January 27, 2026 11:30
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_protocol_upgrade_for_libp2p_streams branch from 7f6f8ed to 416902f Compare January 27, 2026 11:30
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11064 to 12-24-apollo_propeller_add_prost_codec_for_length-delimited_messages January 27, 2026 11:30
@sirandreww-starkware sirandreww-starkware changed the base branch from 12-24-apollo_propeller_add_prost_codec_for_length-delimited_messages to main-v0.14.1-committer January 27, 2026 12:59
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_protocol_upgrade_for_libp2p_streams branch from 416902f to 79d942e Compare January 27, 2026 13:10
Copy link
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main-v0.14.1-committer with commit 7805f2d Jan 27, 2026
33 of 36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments