apollo_propeller: add core unit struct with accessors

[sirandreww-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

• apollo_propeller: add minimal config #11196 : 2 dependent PRs (#11197 , #11942 )
• apollo_propeller: add behaviour skeleton #11195
• apollo_propeller: add Event enum to types #11194
• apollo_propeller: add dial upgrade error handling to handler #11074
• apollo_propeller: add rate-limited queue length warnings #11073
• apollo_propeller: add concurrent streams support to handler #11072
• apollo_propeller: implement outbound substream with message batching #11071
• apollo_propeller: add handler helper methods #11070
• apollo_propeller: use protobuf type in handler send queue #11069
• apollo_propeller: reorder handler structs #11068
• apollo_propeller: add inbound substream handling to receive units #11067
• apollo_propeller: add receive queue and emit logic to handler #11066
• apollo_propeller: add handler skeleton with TODOs #11065
• apollo_propeller: add protocol upgrade for libp2p streams #11064
• apollo_protobuf: add prost codec for length-delimited messages #11063
• apollo_propeller: add protobuf conversions for PropellerUnit #11062
• apollo_propeller: add merkle proof verification to validator #11061
• apollo_propeller: integrate tree origin verification in validator #11060
• apollo_propeller: add tree origin verification methods #11059
• apollo_propeller: add unit validator with signature caching #11058
• apollo_propeller: add tree topology core logic #11057
• apollo_propeller: add shard validation error type #11056
• apollo_propeller: add peer set error type #11055
• apollo_propeller: add core unit struct with accessors #11054 👈 (View in Graphite)
• apollo_propeller: add signature verification module #11053
• apollo_propeller: add reconstruction error type #11052
• apollo_propeller: add shard publish error type #11051
• apollo_propeller: add tree generation error type #11050
• apollo_propeller: add ShardSignatureVerificationError #11049
• apollo_propeller: add base types (Channel, ShardIndex, MessageRoot) #11048
• apollo_propeller: add reed-solomon erasure coding #11047
• apollo_propeller: added merkle implementation tests #11206 : 1 other dependent PR (#11572 )
• apollo_propeller: added merkle tree builder #11205
• apollo_propeller: added model merkle implementation #10985
• apollo_propeller: added model merkle proof implementation #11204
• apollo_protobuf: added propeller proto file #10654
• apollo_propeller: new crate for the propeller p2p protocol #11192
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[guy-starkware]

@guy-starkware reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware, @ShahakShama, and @sirandreww-starkware).

---

crates/apollo_propeller/src/unit.rs line 67 at r1 (raw file):

        self.root
    }
}

Do we really need all these getters? I haven't seen other structs get everything re-routed into getters in other places.

Code quote:

    pub fn channel(&self) -> Channel {
        self.channel
    }

    pub fn publisher(&self) -> PeerId {
        self.publisher
    }

    pub fn signature(&self) -> &[u8] {
        &self.signature
    }

    pub fn index(&self) -> ShardIndex {
        self.index
    }

    pub fn shard(&self) -> &[u8] {
        &self.shard
    }

    pub fn shard_mut(&mut self) -> &mut Vec<u8> {
        &mut self.shard
    }

    pub fn proof(&self) -> &MerkleProof {
        &self.proof
    }

    pub fn root(&self) -> MessageRoot {
        self.root
    }
}

---

crates/apollo_propeller/src/unit.rs line 70 at r1 (raw file):

#[cfg(test)]
mod tests {

You should move these to a different file, then you would have a file named unit_test which is apt

[guy-starkware]

@guy-starkware made 1 comment.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware, @ShahakShama, and @sirandreww-starkware).

---

crates/apollo_propeller/src/unit.rs line 70 at r1 (raw file):

Previously, guy-starkware wrote…

You should move these to a different file, then you would have a file named unit_test which is apt

Although the tests seems pretty trivial IMHO, I would be ok removing these altogether. But that's for your consideration.

[sirandreww-starkware]

@sirandreww-starkware made 2 comments.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @guy-starkware, @noamsp-starkware, and @ShahakShama).

---

crates/apollo_propeller/src/unit.rs line 67 at r1 (raw file):

Previously, guy-starkware wrote…

Do we really need all these getters? I haven't seen other structs get everything re-routed into getters in other places.

These are used throughout the code to do validation and checking, I could have made these fields public but this way I control the mutability of the object very tightly. I added a TODO to consider making all fields public in the future.

---

crates/apollo_propeller/src/unit.rs line 70 at r1 (raw file):

Previously, guy-starkware wrote…

Although the tests seems pretty trivial IMHO, I would be ok removing these altogether. But that's for your consideration.

I removed the test

[guy-starkware]

@guy-starkware reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware and @ShahakShama).

[ShahakShama]

@ShahakShama reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

[github-actions]

Artifacts upload workflows:

• Started at 2026-01-15T18:26:44Z

[sirandreww-starkware]

@sirandreww-starkware reviewed 6 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).