Skip to content

blockifier: box ExecutionError in ctor error #7636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorimedini-starkware merged 1 commit into from
Jun 30, 2025
Merged

blockifier: box ExecutionError in ctor error #7636

dorimedini-starkware merged 1 commit into from
Jun 30, 2025

Conversation

@dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Jun 27, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Jun 27, 2025

This change is Reviewable

@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Jun 27, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 27, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Jun 27, 2025 •
edited
Loading

Artifacts upload workflows:

This was referenced Jun 27, 2025
Merged
Merged
Merged
Merged
@dorimedini-starkware dorimedini-starkware self-assigned this Jun 27, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review June 27, 2025 10:54
amosStarkware
amosStarkware approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

crates/blockifier/src/transaction/transactions_test.rs line 2214 at r1 (raw file):

            *error,
            EntryPointExecutionError::StateError(StateError::UndeclaredClassHash(class_hash))
            if class_hash == undeclared_hash

non blocking - using && instead of nested if is better IMO

Code quote:

if class_hash == undeclared_hash

@dorimedini-starkware dorimedini-starkware changed the base branch from 06-26-blockifier_box_cairorunerror to main June 30, 2025 09:38
@dorimedini-starkware dorimedini-starkware force-pushed the 06-26-blockifier_box_executionerror_in_ctor_error branch from faf5038 to 887d6b9 Compare June 30, 2025 09:38
@graphite-app
Copy link

graphite-app bot commented Jun 30, 2025

Merge activity

  • Jun 30, 9:39 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

dorimedini-starkware
dorimedini-starkware commented Jun 30, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

crates/blockifier/src/transaction/transactions_test.rs line 2214 at r1 (raw file):

Previously, amosStarkware wrote…

non blocking - using && instead of nested if is better IMO

not sure what you are suggesting..? there is only one condition being checked here (note that I need an outer if matches! to destructure)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 64fcf0f Jun 30, 2025
18 checks passed
@dorimedini-starkware dorimedini-starkware mentioned this pull request Jul 1, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amosStarkware amosStarkware amosStarkware approved these changes

Assignees

@dorimedini-starkware dorimedini-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dorimedini-starkware @reviewable-StarkWare @amosStarkware