blockifier: box TransactionPreValidationError in TransactionExecutionError #7639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2025
|
This change is |
Collaborator
Author
This was referenced Jun 27, 2025
|
Artifacts upload workflows: |
Merged
dorimedini-starkware
force-pushed
the
06-27-blockifier_box_transactionfeeerror_in_transactionexecutionerror
branch
from
0e9a7fa to
f48901c
Compare
dorimedini-starkware
force-pushed
the
06-27-blockifier_box_transactionprevalidationerror_in_transactionexecutionerror
branch
from
40ac03e to
83d6b0b
Compare
amosStarkware
approved these changes
Jun 30, 2025
Collaborator
amosStarkware
left a comment
amosStarkware
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
dorimedini-starkware
force-pushed
the
06-27-blockifier_box_transactionfeeerror_in_transactionexecutionerror
branch
from
f48901c to
9ed72f2
Compare
dorimedini-starkware
force-pushed
the
06-27-blockifier_box_transactionprevalidationerror_in_transactionexecutionerror
branch
from
83d6b0b to
d18b935
Compare
dorimedini-starkware
changed the base branch from
06-27-blockifier_box_transactionfeeerror_in_transactionexecutionerror
to
main
Collaborator
Author
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.