Skip to content

blockifier: box ValidateTransactionError in TransactionExecutionError #7640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorimedini-starkware merged 3 commits into from
Jul 1, 2025
Merged

blockifier: box ValidateTransactionError in TransactionExecutionError #7640

dorimedini-starkware merged 3 commits into from
Jul 1, 2025

Conversation

@dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Jun 27, 2025

No description provided.

This was referenced Jun 27, 2025
Merged
Merged
@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Jun 27, 2025

This change is Reviewable

This was referenced Jun 27, 2025
Merged
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Jun 27, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 27, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Jun 27, 2025 •
edited
Loading

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware self-assigned this Jun 27, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review June 27, 2025 10:54
@dorimedini-starkware dorimedini-starkware force-pushed the 06-27-blockifier_box_transactionprevalidationerror_in_transactionexecutionerror branch from 40ac03e to 83d6b0b Compare June 30, 2025 11:23
@dorimedini-starkware dorimedini-starkware force-pushed the 06-27-blockifier_box_validatetransactionerror_in_transactionexecutionerror branch from e64172f to e275910 Compare June 30, 2025 11:23
amosStarkware
amosStarkware approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

-- commits line 2 at r1:
you're boxing RecursionDepthExceeded in ValidateTransactionError, no?

Code quote:

 e275910: blockifier: box ValidateTransactionError in TransactionExecutionError

amosStarkware
amosStarkware approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

-- commits line 2 at r1:

Previously, amosStarkware wrote…

you're boxing RecursionDepthExceeded in ValidateTransactionError, no?

scratch that: EntryPointExecutionError in ValidateTransactionError, no?

@dorimedini-starkware dorimedini-starkware force-pushed the 06-27-blockifier_box_transactionprevalidationerror_in_transactionexecutionerror branch from 83d6b0b to d18b935 Compare June 30, 2025 12:14
@dorimedini-starkware dorimedini-starkware force-pushed the 06-27-blockifier_box_validatetransactionerror_in_transactionexecutionerror branch from e275910 to 04e09a6 Compare June 30, 2025 12:14
dorimedini-starkware
dorimedini-starkware commented Jun 30, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)

-- commits line 2 at r1:

Previously, amosStarkware wrote…

scratch that: EntryPointExecutionError in ValidateTransactionError, no?

right, but the point is reducing the size of ValidateTransactionError in TransactionExecutionError

amosStarkware
amosStarkware approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware changed the base branch from 06-27-blockifier_box_transactionprevalidationerror_in_transactionexecutionerror to main June 30, 2025 14:24
dorimedini-starkware
dorimedini-starkware commented Jun 30, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit cbfa9f1 Jul 1, 2025
38 of 42 checks passed
@dorimedini-starkware dorimedini-starkware mentioned this pull request Jul 1, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amosStarkware amosStarkware amosStarkware approved these changes

Assignees

@dorimedini-starkware dorimedini-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dorimedini-starkware @reviewable-StarkWare @amosStarkware