blockifier: box ValidateTransactionError in TransactionExecutionError#7640
Conversation
|
This change is |
|
Artifacts upload workflows: |
dorimedini-starkware
force-pushed
the
06-27-blockifier_box_transactionprevalidationerror_in_transactionexecutionerror
branch
from
40ac03e to
83d6b0b
Compare
dorimedini-starkware
force-pushed
the
06-27-blockifier_box_validatetransactionerror_in_transactionexecutionerror
branch
from
e64172f to
e275910
Compare
amosStarkware
left a comment
amosStarkware
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
-- commits line 2 at r1:
you're boxing RecursionDepthExceeded in ValidateTransactionError, no?
Code quote:
e275910: blockifier: box ValidateTransactionError in TransactionExecutionError
amosStarkware
left a comment
amosStarkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
Previously, amosStarkware wrote…
you're boxing
RecursionDepthExceededinValidateTransactionError, no?
scratch that: EntryPointExecutionError in ValidateTransactionError, no?
dorimedini-starkware
force-pushed
the
06-27-blockifier_box_transactionprevalidationerror_in_transactionexecutionerror
branch
from
83d6b0b to
d18b935
Compare
dorimedini-starkware
force-pushed
the
06-27-blockifier_box_validatetransactionerror_in_transactionexecutionerror
branch
from
e275910 to
04e09a6
Compare
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)
Previously, amosStarkware wrote…
scratch that:
EntryPointExecutionErrorinValidateTransactionError, no?
right, but the point is reducing the size of ValidateTransactionError in TransactionExecutionError
amosStarkware
left a comment
amosStarkware
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
dorimedini-starkware
changed the base branch from
06-27-blockifier_box_transactionprevalidationerror_in_transactionexecutionerror
to
main
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:
3 participants
No description provided.