ci: rust 1.88 #7711
Merged
ci: rust 1.88 #7711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Jul 1, 2025
Collaborator
Author
Merged
dorimedini-starkware
force-pushed
the
07-01-ci_rust_1.88
branch
from
c6eae35 to
e17e9b8
Compare
Collaborator
Author
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 135 files reviewed, all discussions resolved
a discussion (no related file):
- upgraded to rust 1.88
- ran
cargo clippy --workspace --all-targets --all-features --fix
what clippy did:
- changed
format!("{}", x)->format!("{x}") - changed
map.iter().map(|(_k, v)| ..)->map.values().map(|v| ..)
|
Benchmark movements: No major performance changes detected. |
dorimedini-starkware
force-pushed
the
07-01-ci_rust_1.88
branch
from
e17e9b8 to
66f78c6
Compare
dorimedini-starkware
force-pushed
the
06-27-ci_rust_1.87
branch
from
effb0c3 to
f8d4faf
Compare
dorimedini-starkware
force-pushed
the
07-01-ci_rust_1.88
branch
from
66f78c6 to
c1fb3e3
Compare
dorimedini-starkware
force-pushed
the
06-27-ci_rust_1.87
branch
from
f8d4faf to
6abb809
Compare
dorimedini-starkware
force-pushed
the
07-01-ci_rust_1.88
branch
from
c1fb3e3 to
a60b0a3
Compare
dorimedini-starkware
force-pushed
the
07-01-ci_rust_1.88
branch
from
a60b0a3 to
f4ad725
Compare
matanl-starkware
approved these changes
Jul 6, 2025
Collaborator
matanl-starkware
left a comment
matanl-starkware
left a comment
There was a problem hiding this comment.
Reviewed 135 of 135 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.