Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jun 27, 2025

@dorimedini-starkware dorimedini-starkware self-assigned this Jun 27, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review June 27, 2025 10:54
@dorimedini-starkware dorimedini-starkware force-pushed the 06-27-native_blockifier_apollo_gateway_some_allow_result_large_err branch from a6efcf8 to e963961 Compare June 30, 2025 11:23
@dorimedini-starkware dorimedini-starkware force-pushed the 06-27-native_blockifier_apollo_gateway_some_allow_result_large_err branch from e963961 to c064327 Compare June 30, 2025 12:14
@dorimedini-starkware dorimedini-starkware force-pushed the 06-27-native_blockifier_apollo_gateway_some_allow_result_large_err branch from c064327 to c0bb6ae Compare July 1, 2025 11:35
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


rust-toolchain.toml line 2 at r1 (raw file):

[toolchain]
channel = "1.87"

is there no file in the repo that defines what Rust version to run locally?
i.e., if I'm running a test / some target locally, what decides what Rust version I'm using? only my installed version?
if yes - should we tell people to upgrade their installation, or is this not needed because 1.86->1.87 isn't breaking?

Code quote:

channel = "1.87"

@dorimedini-starkware dorimedini-starkware force-pushed the 06-27-native_blockifier_apollo_gateway_some_allow_result_large_err branch from c0bb6ae to 678df47 Compare July 3, 2025 08:19
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)


rust-toolchain.toml line 2 at r1 (raw file):

Previously, amosStarkware wrote…

is there no file in the repo that defines what Rust version to run locally?
i.e., if I'm running a test / some target locally, what decides what Rust version I'm using? only my installed version?
if yes - should we tell people to upgrade their installation, or is this not needed because 1.86->1.87 isn't breaking?

when you run cargo commands, the rust-toolchain.toml is checked and the required tooling is auto-installed.
you should already have 1.87 installed locally (this is the rust version currently on main-v0.14.0).
if you want to test this - checkout the next branch (07-01-ci_rust_1.88), and run cargo build workspace_tests or some short cargo command. you should see rust 1.88 being installed

@dorimedini-starkware dorimedini-starkware changed the base branch from 06-27-native_blockifier_apollo_gateway_some_allow_result_large_err to main July 3, 2025 09:56
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

Benchmark movements: tree_computation_flow performance improved 😺 tree_computation_flow time: [34.387 ms 34.424 ms 34.464 ms] change: [-5.3429% -3.6168% -2.0286%] (p = 0.00 < 0.05) Performance has improved. Found 8 outliers among 100 measurements (8.00%) 6 (6.00%) high mild 2 (2.00%) high severe

Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 791a8aa Jul 3, 2025
34 of 35 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants