apollo_rpc_execution: box TransactionFeeError in ExecutionError #7642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2025
|
This change is |
This was referenced Jun 27, 2025
Collaborator
Author
This was referenced Jun 27, 2025
Merged
dorimedini-starkware
force-pushed
the
06-27-blockifier_box_transactionfeeerror_in_transactionprevalidationerror
branch
from
079d3a4 to
6786b24
Compare
dorimedini-starkware
force-pushed
the
06-27-apollo_rpc_execution_box_transactionfeeerror_in_executionerror
branch
from
d31f00d to
108deb0
Compare
dorimedini-starkware
force-pushed
the
06-27-blockifier_box_transactionfeeerror_in_transactionprevalidationerror
branch
from
6786b24 to
0b1815b
Compare
dorimedini-starkware
force-pushed
the
06-27-apollo_rpc_execution_box_transactionfeeerror_in_executionerror
branch
from
108deb0 to
00c9691
Compare
graphite-app
bot
changed the base branch from
06-27-blockifier_box_transactionfeeerror_in_transactionprevalidationerror
to
graphite-base/7642
dorimedini-starkware
force-pushed
the
06-27-apollo_rpc_execution_box_transactionfeeerror_in_executionerror
branch
from
00c9691 to
5dc66f0
Compare
|
Artifacts upload workflows: |
Merged
amosStarkware
approved these changes
Jul 3, 2025
Collaborator
amosStarkware
left a comment
amosStarkware
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
amosStarkware
approved these changes
Jul 3, 2025
Collaborator
amosStarkware
left a comment
amosStarkware
left a comment
There was a problem hiding this comment.
Reviewable status:
crates/apollo_rpc_execution/src/lib.rs line 201 at r2 (raw file):
StorageError(#[from] StorageError), #[error(transparent)] TransactionFeeError(#[from] Box<blockifier::transaction::errors::TransactionFeeError>),
Is this not used anywhere?
non blocking
Code quote:
TransactionFeeError(#[from] Box<blockifier::transaction::errors::TransactionFeeError>),
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.