blockifier: box TransactionFeeError in TransactionPreValidationError

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• ci: rust 1.88 #7711
• ci: rust 1.87 #7645
• native_blockifier,apollo_gateway: some allow result_large_err #7644
• native_blockifier: box StatefulValidatorError in NativeBlockifierError #7643
• apollo_rpc_execution: box TransactionFeeError in ExecutionError #7642
• blockifier: box TransactionFeeError in TransactionPreValidationError #7641 👈 (View in Graphite)
• blockifier: box ValidateTransactionError in TransactionExecutionError #7640
• blockifier: box TransactionPreValidationError in TransactionExecutionError #7639
• blockifier: box TransactionFeeError in TransactionExecutionError #7638
• blockifier: box ExecutionError in TransactionExecutionError #7637
• blockifier: box ExecutionError in ctor error #7636
• blockifier: box CairoRunError #7635
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-06-27T10:51:48Z
• Started at 2025-06-30T11:23:19Z
• Started at 2025-06-30T12:14:33Z
• Started at 2025-07-01T10:25:29Z

[dorimedini-starkware]

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @amosStarkware)

---

crates/apollo_gateway/src/stateful_transaction_validator_test.rs line 56 at r1 (raw file):

            },
        ),
    );

1. only used once (inlined below)
2. Box fields can't be const

Code quote:

pub const STATEFUL_VALIDATOR_FEE_ERROR: BlockifierStatefulValidatorError =
    BlockifierStatefulValidatorError::TransactionPreValidationError(
        TransactionPreValidationError::TransactionFeeError(
            TransactionFeeError::GasBoundsExceedBalance {
                resource: Resource::L1DataGas,
                max_amount: GasAmount(VALID_L1_GAS_MAX_AMOUNT),
                max_price: GasPrice(VALID_L1_GAS_MAX_PRICE_PER_UNIT),
                balance: BigUint::ZERO,
            },
        ),
    );

[amosStarkware]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/transaction/execution_flavors_test.rs line 283 at r1 (raw file):

            err,
            TransactionExecutionError::TransactionPreValidationError(boxed_error)
            => assert_matches!(

There's no difference between an assert_matches! and a guard expression here?

Code quote:

 => assert_matches!(

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)

---

crates/blockifier/src/transaction/execution_flavors_test.rs line 283 at r1 (raw file):

Previously, amosStarkware wrote…

There's no difference between an assert_matches! and a guard expression here?

not sure what you mean
if you're asking why can't i do

if matches!(
    x,
    Y::(boxed_y),
    if matches!(
        *boxed_y,
        Z::ZY(y),
        if y == expected_y
    )
)

it's because rust complained about ownership; I think moving boxed_y into the inner matches! violates ownership rules

[amosStarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[graphite-app]

Merge activity

• Jul 1, 10:26 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.