Skip to content

apollo_propeller: add rate-limited queue length warnings#11073

Merged
sirandreww-starkware merged 2 commits intomain-v0.14.2from
12-24-apollo_propeller_add_rate-limited_queue_length_warnings
Feb 19, 2026
Merged

apollo_propeller: add rate-limited queue length warnings#11073
sirandreww-starkware merged 2 commits intomain-v0.14.2from
12-24-apollo_propeller_add_rate-limited_queue_length_warnings

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Dec 24, 2025

Note

Low Risk
Logging-only behavior change with minimal functional impact; main risk is added log noise or small runtime overhead under sustained backlog conditions.

Overview
Adds apollo_infra_utils as a dependency for apollo_propeller and uses warn_every_n_ms! to emit rate-limited warnings when the handler’s send_queue or events_to_emit exceeds a configurable threshold.

Also adds constants to tune the backlog threshold/interval and documents a potential starvation issue in poll_send when CONCURRENT_STREAMS is increased above 1.

Written by Cursor Bugbot for commit f858894. This will update automatically on new commits. Configure here.

This was referenced Dec 24, 2025
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_concurrent_streams_support_to_handler branch from bfe9644 to 5a11585 Compare February 18, 2026 09:01
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_rate-limited_queue_length_warnings branch 2 times, most recently from 1c71684 to c20f35b Compare February 18, 2026 14:40
@sirandreww-starkware sirandreww-starkware changed the base branch from 12-24-apollo_propeller_add_concurrent_streams_support_to_handler to graphite-base/11073 February 19, 2026 09:00
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_rate-limited_queue_length_warnings branch from c20f35b to 7c9b29b Compare February 19, 2026 09:49
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11073 to 12-24-apollo_propeller_add_concurrent_streams_support_to_handler February 19, 2026 09:49
@graphite-app graphite-app bot changed the base branch from 12-24-apollo_propeller_add_concurrent_streams_support_to_handler to graphite-base/11073 February 19, 2026 10:38
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_rate-limited_queue_length_warnings branch from 7c9b29b to c9827a6 Compare February 19, 2026 10:42
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11073 to 12-24-apollo_propeller_add_concurrent_streams_support_to_handler February 19, 2026 10:42
@sirandreww-starkware sirandreww-starkware changed the base branch from 12-24-apollo_propeller_add_concurrent_streams_support_to_handler to main-v0.14.1-committer February 19, 2026 11:06
@sirandreww-starkware sirandreww-starkware changed the base branch from main-v0.14.1-committer to graphite-base/11073 February 19, 2026 11:13
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_rate-limited_queue_length_warnings branch from c9827a6 to 878de7f Compare February 19, 2026 11:13
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11073 to main-v0.14.2 February 19, 2026 11:13
@graphite-app graphite-app bot changed the base branch from main-v0.14.2 to main-v0.14.1-committer February 19, 2026 11:13
@sirandreww-starkware sirandreww-starkware changed the base branch from main-v0.14.1-committer to graphite-base/11073 February 19, 2026 11:19
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11073 to main-v0.14.2 February 19, 2026 11:19
@graphite-app graphite-app bot changed the base branch from main-v0.14.2 to main-v0.14.1-committer February 19, 2026 11:20
@graphite-app
Copy link

graphite-app bot commented Feb 19, 2026

Merge activity

  • Feb 19, 11:20 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Feb 19, 11:20 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@sirandreww-starkware sirandreww-starkware changed the base branch from main-v0.14.1-committer to main-v0.14.2 February 19, 2026 13:15
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_rate-limited_queue_length_warnings branch from 878de7f to f858894 Compare February 19, 2026 13:16
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main-v0.14.2 with commit b2042bf Feb 19, 2026
32 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments