apollo_propeller: add dial upgrade error handling to handler#11074
Conversation
6d39d68 to
21e2ab0
Compare
21e2ab0 to
874e9e8
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama).
crates/apollo_propeller/src/handler.rs line 499 at r6 (raw file):
Previously, ShahakShama wrote…
I think this can be warn. If this bug occurs we want to know about it. maybe warn once every second
Done.
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama).
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware).
874e9e8 to
dfd8ca5
Compare
863c895 to
46f1337
Compare
dfd8ca5 to
44acafd
Compare
46f1337 to
1c71684
Compare
44acafd to
d80d6a8
Compare
1c71684 to
7c9b29b
Compare
7c9b29b to
c9827a6
Compare
d80d6a8 to
ad16d48
Compare
c9827a6 to
878de7f
Compare
ad16d48 to
7b7a8e1
Compare
Merge activity
|
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware).
878de7f to
e859754
Compare
7b7a8e1 to
7240134
Compare

Note
Low Risk
Logging-only change on the
DialUpgradeErrorpath; no protocol or data-flow behavior changes beyond additional rate-limited warnings.Overview
Enhances
Handlerdial-upgrade failure handling by matching onStreamUpgradeErrorand emitting more specific logs for timeouts, negotiation failures (rate-limited), and I/O errors.Introduces
DIAL_UPGRADE_WARNING_INTERVAL_MSto throttle repeated warnings when a peer doesn’t support the Propeller protocol, while keeping the existing state reset of the affected pending outbound substream back toIdle.Written by Cursor Bugbot for commit 7240134. This will update automatically on new commits. Configure here.