Skip to content

apollo_propeller: add dial upgrade error handling to handler#11074

Merged
sirandreww-starkware merged 1 commit intomain-v0.14.2from
12-24-apollo_propeller_add_dial_upgrade_error_handling_to_handler
Feb 19, 2026
Merged

apollo_propeller: add dial upgrade error handling to handler#11074
sirandreww-starkware merged 1 commit intomain-v0.14.2from
12-24-apollo_propeller_add_dial_upgrade_error_handling_to_handler

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Dec 24, 2025

Note

Low Risk
Logging-only change on the DialUpgradeError path; no protocol or data-flow behavior changes beyond additional rate-limited warnings.

Overview
Enhances Handler dial-upgrade failure handling by matching on StreamUpgradeError and emitting more specific logs for timeouts, negotiation failures (rate-limited), and I/O errors.

Introduces DIAL_UPGRADE_WARNING_INTERVAL_MS to throttle repeated warnings when a peer doesn’t support the Propeller protocol, while keeping the existing state reset of the affected pending outbound substream back to Idle.

Written by Cursor Bugbot for commit 7240134. This will update automatically on new commits. Configure here.

This was referenced Dec 24, 2025
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_dial_upgrade_error_handling_to_handler branch from 6d39d68 to 21e2ab0 Compare February 16, 2026 12:08
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11074 to 12-24-apollo_propeller_add_rate-limited_queue_length_warnings February 16, 2026 12:08
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_dial_upgrade_error_handling_to_handler branch from 21e2ab0 to 874e9e8 Compare February 16, 2026 12:12
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama).


crates/apollo_propeller/src/handler.rs line 499 at r6 (raw file):

Previously, ShahakShama wrote…

I think this can be warn. If this bug occurs we want to know about it. maybe warn once every second

Done.

Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama).

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_dial_upgrade_error_handling_to_handler branch from 874e9e8 to dfd8ca5 Compare February 18, 2026 08:36
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_rate-limited_queue_length_warnings branch from 863c895 to 46f1337 Compare February 18, 2026 08:36
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_dial_upgrade_error_handling_to_handler branch from dfd8ca5 to 44acafd Compare February 18, 2026 09:01
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_rate-limited_queue_length_warnings branch from 46f1337 to 1c71684 Compare February 18, 2026 09:01
@sirandreww-starkware sirandreww-starkware changed the base branch from 12-24-apollo_propeller_add_rate-limited_queue_length_warnings to graphite-base/11074 February 18, 2026 14:40
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_dial_upgrade_error_handling_to_handler branch from 44acafd to d80d6a8 Compare February 19, 2026 09:49
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11074 to 12-24-apollo_propeller_add_rate-limited_queue_length_warnings February 19, 2026 09:49
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_rate-limited_queue_length_warnings branch from 7c9b29b to c9827a6 Compare February 19, 2026 10:42
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_dial_upgrade_error_handling_to_handler branch from d80d6a8 to ad16d48 Compare February 19, 2026 10:42
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_rate-limited_queue_length_warnings branch from c9827a6 to 878de7f Compare February 19, 2026 11:13
@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_dial_upgrade_error_handling_to_handler branch from ad16d48 to 7b7a8e1 Compare February 19, 2026 11:13
@sirandreww-starkware sirandreww-starkware changed the base branch from 12-24-apollo_propeller_add_rate-limited_queue_length_warnings to graphite-base/11074 February 19, 2026 11:19
@graphite-app
Copy link

graphite-app bot commented Feb 19, 2026

Merge activity

  • Feb 19, 2:20 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Feb 19, 2:20 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on noamsp-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 12-24-apollo_propeller_add_dial_upgrade_error_handling_to_handler branch from 7b7a8e1 to 7240134 Compare February 19, 2026 15:36
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11074 to main-v0.14.2 February 19, 2026 15:36
@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main-v0.14.2 with commit e744e07 Feb 19, 2026
16 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments